remove reference to Configure: Kubernetes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section effectively configures the pod to relabel its bind-mounted files, which include important files on the host which should not be relabeled unless the user knows exactly what will happen. This is likely not the best advice for users running on SELinux-enabled Kubernetes clusters. We need to find an equivalent to OpenShift's SecurityContextConstraints which configure what SELinux label the container process must run as, instead of relabeling the file system. Until we have that guidance, I think we should remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section effectively configures the pod to relabel its bind-mounted files, which include important files on the host which should not be relabeled unless the user knows exactly what will happen.
This is likely not the best advice for users running on SELinux-enabled Kubernetes clusters. We need to find an equivalent to OpenShift's SecurityContextConstraints which configure what SELinux label the container process must run as, instead of relabeling the file system. Until we have that guidance, I think we should remove this.